Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DPoPInterceptor when called after retry #1536

Merged

Conversation

clementdenis
Copy link
Contributor

Issue(s)

If a request is retried, it's possible that the Authorization header is already modified with "DPoP" prefix instead of "Bearer"
=> in that case the request will fail because the authorization header and the ath claim in the DPoP token will be wrong.

Description

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the base branch from master to fix_dpop_retry August 30, 2024 18:13
@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit 2dce236 into okta:fix_dpop_retry Aug 30, 2024
arvindkrishnakumar-okta added a commit that referenced this pull request Sep 3, 2024
Co-authored-by: Clément Denis <clement.denis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants