Add automatic support for DPoP #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DPoPInterceptor when authentication with PRIVATE_KEY - Supports nonce refreshing
arvindkrishnakumar-okta
changed the title
arvindkrishnakumar-okta
requested review from
duytiennguyen-okta,
laura-rodriguez,
bryanapellanes-okta and
monde
arvindkrishnakumar-okta
changed the title
duytiennguyen-okta
approved these changes
May 7, 2024
| @@ -113,7 +129,7 @@ private void processRequest(HttpRequest request, boolean tokenRequest) { | |||
|
|
|||
| private String getUriWithoutQueryString(HttpRequest request) { | |||
| try { | |||
| return StringUtils.substringBefore(request.getUri().toString(), "?"); | |||
| return URLDecoder.decode(StringUtils.substringBefore(request.getUri().toString(), "?"), StandardCharsets.UTF_8); | |||
There was a problem hiding this comment.
@arvindkrishnakumar-okta This method is only available since Java 10 => will break Java 8/9 users.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
OKTA-721225
Description
Add DPoP support.
https://datatracker.ietf.org/doc/html/rfc9449#section-4.2
Category
Signoff