Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApiClient NPE #1129

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Fix ApiClient NPE #1129

merged 2 commits into from
Apr 30, 2024

Conversation

arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta arvindkrishnakumar-okta commented Apr 30, 2024 •
edited
Loading

Issue(s)

Thanks to @clementdenis for the original PR #1128

Description

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

clementdenis and others added 2 commits April 30, 2024 10:16
@clementdenis
Fix NPE when using the no-arg constructor of ApiClient (#1127)
73e96e8 
- Check both httpClient and cacheManager are non-null
- Add unit tests
- Also cleanup unused fields
@arvindkrishnakumar-okta
fix test
553ff81
@arvindkrishnakumar-okta arvindkrishnakumar-okta changed the title Ak fix apiclient npe Fix ApiClient NPE Apr 30, 2024
@arvindkrishnakumar-okta arvindkrishnakumar-okta merged commit a575e9a into master Apr 30, 2024
0 of 2 checks passed
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the ak_fix_apiclient_npe branch April 30, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duytiennguyen-okta duytiennguyen-okta duytiennguyen-okta approved these changes

@monde monde Awaiting requested review from monde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvindkrishnakumar-okta @duytiennguyen-okta @clementdenis