Implement custom JWT assertion signing #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can be used to sign with KMS services instead of local private key
arvindkrishnakumar-okta
approved these changes
May 9, 2024
13 tasks
arvindkrishnakumar-okta
added a commit
that referenced
this pull request
May 15, 2024
* Implement custom JWT assertion signing (#1001) - Can be used to sign with KMS services instead of local private key * added typeInfoAnnotation mustache template * cleanup unused import --------- Co-authored-by: Clément Denis <clement.denis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
#878
Description
I reworked my previous attempt after JJWT was migrated to 0.12+.
This is one is a bit cleaner and less hacky (still have to pass a 'dummy' key to the JwtBuilder, no workaround for this, unless JJWT changes its API).
Category
Signoff