Skip to content

Commit

Permalink
fixed few review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
arvindkrishnakumar-okta committed Jul 2, 2020
1 parent b93f036 commit b836376
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 6 additions & 8 deletions MIGRATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,21 @@ Following is a list of changes that break backward compatibility in version 2.0.
- Renamed `listRules` to `listGroupRules`

- `com.okta.sdk.resource.log.LogEventList`
- `getLogs(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String)`
Signature changed to `getLogs(java.util.Date, java.util.Date, java.lang.String, java.lang.String, java.lang.String)`
- `getLogs(String until, String since, String filter, String q, String sortOrder)`
Signature changed to `getLogs(Date since, Date until, String filter, String q, String sortOrder)`

- `com.okta.sdk.resource.group.GroupList`
- `listGroups(java.lang.String,java.lang.String, java.lang.String)`
Signature changed to `listGroups(java.lang.String, java.lang.String)`

- `com.okta.sdk.resource.application.JsonWebKey`
- `getExpiresAt` Return type changed from `Date` to `String`
- `listGroups(String q, String filter, String expand)`
Signature changed to `listGroups(String q, String filter)`

- `com.okta.sdk.resource.application.SwaThreeFieldApplicationSettingsApplication`
- `getTargetUrl` Renamed to `getTargetURL`
- `setTargetUrl` Renamed to `setTargetURL`

- `com.okta.sdk.resource.group.Group`
- `getType` Return type changed from `String` to `com.okta.sdk.resource.group.GroupType`

- Removed `listUsers`

- `com.okta.sdk.resource.group.rule.GroupRule`
- Removed `delete`
- Removed `getAllGroupsValid`
Expand Down
2 changes: 2 additions & 0 deletions src/swagger/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8817,6 +8817,8 @@ definitions:
readOnly: true
type: string
expiresAt:
format: date-time
readOnly: true
type: string
key_ops:
items:
Expand Down

0 comments on commit b836376

Please sign in to comment.