Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of E2E tests #279

Merged
merged 9 commits into from
Apr 5, 2021

Conversation

oleggnidets-okta
Copy link
Contributor

@oleggnidets-okta oleggnidets-okta commented Mar 29, 2021

Problem Analysis (Technical)

UI tests are failing in ~50% of time.

Solution (Technical)

Refactor existing UI tests. Used default framework' methods for waiting elements. Added better support of waiting text. Removed outdated code.
Additionally
Updated Xcode project, added app icon.
Updated travis.yml to parallelize jobs.

Screenshot 2021-03-30 at 12 12 01

Affected Components

UI tests.

Copy link
Collaborator

@mikenachbaur-okta mikenachbaur-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the direction this is headed. The tests are much cleaner, and I like the extra documentation and attention to detail.

I only have some minor comments / questions.

Copy link
Collaborator

@mikenachbaur-okta mikenachbaur-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@oleggnidets-okta oleggnidets-okta removed the request for review from IldarAbdullin-okta April 5, 2021 07:23
@oleggnidets-okta oleggnidets-okta merged commit 6c82937 into master Apr 5, 2021
@oleggnidets-okta oleggnidets-okta deleted the ognidets_OKTA-381433_Fix-E2E-tests branch April 5, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants