Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Role Permission Properties #3353

Merged
merged 1 commit into from
May 18, 2022

Conversation

MikeMondragon-okta
Copy link
Contributor

Description:

okta.profilesource.import.run is typo'd and should be plural okta.profil…esources.import.run

Error

# 400 bad request
POST /api/v1/iam/roles
{
      "label": "Test",
      "description": "Test",
      "permissions": [
        "okta.users.create",
        "okta.users.read",
        "okta.groups.read",
        "okta.users.userprofile.manage",
        "okta.profilesource.import.run"
      ]
    }
{
    "errorCode": "E0000001",
    "errorSummary": "Api validation failed: permissions",
    "errorLink": "E0000001",
    "errorId": "oaePN_Ve5cKS7mxM3oW3CAJew",
    "errorCauses": [
        {
            "errorSummary": "permissions: Invalid public permission name: okta.profilesource.import.run"
        }
    ]
}

Pass

# 200 OK
POST /api/v1/iam/roles
{
      "label": "Test",
      "description": "Test",
      "permissions": [
        "okta.users.create",
        "okta.users.read",
        "okta.groups.read",
        "okta.users.userprofile.manage",
        "okta.profilesources.import.run"
      ]
    }

{
    "id": "xxx",
    "label": "Test",
    "description": "Test",
    "created": "2022-05-18T21:08:24.000Z",
    "lastUpdated": "2022-05-18T21:08:24.000Z",
    "_links": {
        "permissions": {
            "href": "https://example.okta.com/api/v1/iam/roles/yyy/permissions"
        },
        "self": {
            "href": "https://example.okta.com/api/v1/iam/roles/yyy"
        }
    }
}

Resolves:

Copy link
Contributor

@susanharper-okta susanharper-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susanharper-okta susanharper-okta merged commit ff53614 into master May 18, 2022
@susanharper-okta susanharper-okta deleted the typo_in_role_permission_properties branch May 18, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants