Enforce strict token validation everywhere. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyhaverstein-okta
approved these changes
Jan 18, 2019
|
|
||
| if (jwtToken.Header?.Alg == null || jwtToken.Header?.Alg != SecurityAlgorithms.RsaSha256) | ||
| { | ||
| throw new SecurityTokenValidationException("The alg must be RS256."); |
There was a problem hiding this comment.
Nitpick: Just calling it "the alg" sounds a bit slangy. Maybe "The JWT token's alg property" or "The JWT token's signing algorithm"?
| { | ||
| private readonly JwtSecurityTokenHandler _handler; | ||
|
|
||
| public StrictSecurityTokenValidator(OktaWebOptions options) |
There was a problem hiding this comment.
nit: Do we need the options constructor parameter? Seems like it isn't used.
There was a problem hiding this comment.
good catch, this is not needed.
| public int MaximumTokenSizeInBytes | ||
| { | ||
| get => _handler.MaximumTokenSizeInBytes; | ||
| set => throw new NotImplementedException(); |
There was a problem hiding this comment.
I'm wondering if we should throw something other than NotImplementedException. Usually when I see that I see it as either a bug in the library that threw it, or an indication that a feature is only partially implemented. But in our case the code is complete, it's just that the property is readonly.
Maybe NotSupportedException? Up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per our JWT spec validate that
algclaim isRS256.