Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for login_hint param #147

Merged
merged 5 commits into from
Sep 21, 2020
Merged

Add support for login_hint param #147

merged 5 commits into from
Sep 21, 2020

Conversation

laura-rodriguez
Copy link
Collaborator

@laura-rodriguez laura-rodriguez commented Sep 18, 2020 •
edited
Loading

  • Add support for login_hint
  • Refactor existing code to make it easier to add support for other Okta params in the future
  • Update Readme with usage examples
  • Fix old StyleCop issues.

Issue #

Fix #142
Fix OKTA-326154

Code

  • Unit test(s)
  • Implementation

andriizhegurov-okta
andriizhegurov-okta approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@andriizhegurov-okta andriizhegurov-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bryanapellanes-okta
bryanapellanes-okta approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@bryanapellanes-okta bryanapellanes-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laura-rodriguez laura-rodriguez merged commit 156466d into master Sep 21, 2020
@laura-rodriguez laura-rodriguez deleted the lr-add-support-for-login-hint branch September 21, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanapellanes-okta bryanapellanes-okta bryanapellanes-okta approved these changes

@andriizhegurov-okta andriizhegurov-okta andriizhegurov-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to specify "login_hint" parameter
3 participants
@laura-rodriguez @bryanapellanes-okta @andriizhegurov-okta