Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add code analyzers #11

Merged
merged 1 commit into from
May 15, 2018
Merged

WIP: Add code analyzers #11

merged 1 commit into from
May 15, 2018

Conversation

nbarbettini
Copy link
Contributor

@nbarbettini nbarbettini commented Apr 28, 2018

Adding the code analyzers used in Okta.Sdk to keep a consistent style.

  • Add StyleCop.Analyzers and configuration
  • Add AsyncUsageAnalyzers
  • Add analyzers to non-.NET Standard projects
  • Fix warnings

@nbarbettini nbarbettini self-assigned this Apr 28, 2018
@nbarbettini nbarbettini requested review from laura-rodriguez and removed request for laura-rodriguez May 15, 2018 03:39
@nbarbettini
Copy link
Contributor Author

Background: When writing Okta.Sdk, I used StyleCop.Analyzers to enforce good code style and keep all of my code consistent. I'd like to do the same thing here, and use the same style rules from Okta.Sdk. In this PR, I copied the style rules from the SDK project and enabled the analyzers in each project.

Tl;dr: Now there are tons of warnings and errors to fix in all the projects. (This is normal when adding analyzers!) The remaining work is to get rid of all the warnings. 😄 Most of them have automatic code fixes (lightbulb icon) in Visual Studio!

@laura-rodriguez laura-rodriguez merged commit f593273 into master May 15, 2018
@nbarbettini nbarbettini deleted the nb-add-stylecop branch May 15, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants