Skip to content

Commit

Permalink
Return from the test and utility examples via exit()
Browse files Browse the repository at this point in the history
All the core examples have been modified not to return from main
by the means of the return statement, but rather via exit() function,
which was done to make the examples more bare metal friendly.

This commit, for the sake of consistency, introduces the modifications
to the test and utility examples. These, while less likely to be used
in the low level environments, won't suffer from such a change.
  • Loading branch information
k-stachowiak committed Aug 16, 2019
1 parent 5e1b195 commit 776521a
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 12 deletions.
4 changes: 2 additions & 2 deletions programs/test/benchmark.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
int main( void )
{
mbedtls_printf("MBEDTLS_TIMING_C not defined.\n");
return( 0 );
mbedtls_exit( 0 );
}
#else

Expand Down Expand Up @@ -999,7 +999,7 @@ int main( int argc, char *argv[] )
fflush( stdout ); getchar();
#endif

return( 0 );
mbedtls_exit( 0 );
}

#endif /* MBEDTLS_TIMING_C */
5 changes: 3 additions & 2 deletions programs/test/udp_proxy.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#define mbedtls_printf printf
#define mbedtls_calloc calloc
#define mbedtls_free free
#define mbedtls_exit exit
#define MBEDTLS_EXIT_SUCCESS EXIT_SUCCESS
#define MBEDTLS_EXIT_FAILURE EXIT_FAILURE
#endif /* MBEDTLS_PLATFORM_C */
Expand All @@ -50,7 +51,7 @@
int main( void )
{
mbedtls_printf( "MBEDTLS_NET_C not defined.\n" );
return( 0 );
mbedtls_exit( 0 );
}
#else

Expand Down Expand Up @@ -964,7 +965,7 @@ int main( int argc, char *argv[] )
fflush( stdout ); getchar();
#endif

return( exit_code );
mbedtls_exit( exit_code );
}

#endif /* MBEDTLS_NET_C */
7 changes: 4 additions & 3 deletions programs/test/zeroize.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#else
#include <stdlib.h>
#define mbedtls_printf printf
#define mbedtls_exit exit
#define MBEDTLS_EXIT_SUCCESS EXIT_SUCCESS
#define MBEDTLS_EXIT_FAILURE EXIT_FAILURE
#endif
Expand Down Expand Up @@ -72,14 +73,14 @@ int main( int argc, char** argv )
{
mbedtls_printf( "This program takes exactly 1 agument\n" );
usage();
return( exit_code );
mbedtls_exit( exit_code );
}

fp = fopen( argv[1], "r" );
if( fp == NULL )
{
mbedtls_printf( "Could not open file '%s'\n", argv[1] );
return( exit_code );
mbedtls_exit( exit_code );
}

while( ( c = fgetc( fp ) ) != EOF && p < end - 1 )
Expand All @@ -97,5 +98,5 @@ int main( int argc, char** argv )
fclose( fp );
mbedtls_platform_zeroize( buf, sizeof( buf ) );

return( exit_code );
mbedtls_exit( exit_code );
}
4 changes: 2 additions & 2 deletions programs/util/pem2der.c
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
int main( void )
{
mbedtls_printf("MBEDTLS_BASE64_C and/or MBEDTLS_FS_IO not defined.\n");
return( 0 );
mbedtls_exit( 0 );
}
#else

Expand Down Expand Up @@ -290,6 +290,6 @@ int main( int argc, char *argv[] )
fflush( stdout ); getchar();
#endif

return( exit_code );
mbedtls_exit( exit_code );
}
#endif /* MBEDTLS_BASE64_C && MBEDTLS_FS_IO */
8 changes: 5 additions & 3 deletions programs/util/strerror.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
#include "mbedtls/platform.h"
#else
#include <stdio.h>
#include <stdlib.h>
#define mbedtls_printf printf
#define mbedtls_exit exit
#endif

#if defined(MBEDTLS_ERROR_C) || defined(MBEDTLS_ERROR_STRERROR_DUMMY)
Expand All @@ -48,7 +50,7 @@
int main( void )
{
mbedtls_printf("MBEDTLS_ERROR_C and/or MBEDTLS_ERROR_STRERROR_DUMMY not defined.\n");
return( 0 );
mbedtls_exit( 0 );
}
#else
int main( int argc, char *argv[] )
Expand All @@ -59,7 +61,7 @@ int main( int argc, char *argv[] )
if( argc != 2 )
{
mbedtls_printf( USAGE );
return( 0 );
mbedtls_exit( 0 );
}

val = strtol( argv[1], &end, 10 );
Expand Down Expand Up @@ -87,6 +89,6 @@ int main( int argc, char *argv[] )
fflush( stdout ); getchar();
#endif

return( val );
mbedtls_exit( val );
}
#endif /* MBEDTLS_ERROR_C */

0 comments on commit 776521a

Please sign in to comment.