This repository has been archived by the owner on Aug 3, 2022. It is now read-only.
upgrade scrypt, node package for node 0.12.x support #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation of opendatacensus from master fails on node installations of 0.12.x
I've confirmed this twice, on my computer locally, and on a friend's (gist of install error).
The scrypt package (node-scrypt), at 1.7.4 in our master, doesn't support node >=0.11. Support for node 0.12 was added in barrysteyn/node-scrypt@223f039
I did a new install of opendatacensus with my updated package.json and was able to locally run it without noticeable problems. There were a couple notices in the terminal while running it.
Here's the results from my mocha test
and the [install log from npm]https://gist.github.com/b985622d1d3c878576f3