Detect changed columns #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdata99
force-pushed
the
changed_columns
branch
from
cdeb5b2 to
527b3d2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR proposes changes related to API token handling and enhanced logging/plugin notifications in the datapusher-plus code.
- Modify get_dp_plus_user_apitoken() to raise an exception when no API token is set.
- Add various logging statements and a new plugin hook call (datastore_before_update) in jobs.py for enhanced datastore update tracking.
- Introduce a new interface method (datastore_before_update) to standardize plugin notifications before datastore updates.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ckanext/datapusher_plus/utils.py | Updated the API token retrieval function to raise an exception instead of falling back to site_user. |
| ckanext/datapusher_plus/jobs.py | Added informative logging statements and a plugin notification hook before datastore updates. |
| ckanext/datapusher_plus/interfaces.py | Added a new interface method datastore_before_update for plugin integrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a proposal