Skip to content

Added additional dependency injection params for PHP-AOP #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "okapi/code-transformer",
"description": "PHP Code Transformer is a PHP library that allows you to modify and transform the source code of a loaded PHP class.",
"version": "1.3.4",
"version": "1.3.5",
"type": "library",
"homepage": "https://github.com/okapi-web/php-code-transformer",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion src/CodeTransformerKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ protected function registerServices(): void
$this->options->register();

$this->transformerManager->registerCustomDependencyInjectionHandler(
$this->dependencyInjectionHandler()
$this->dependencyInjectionHandler(),
);
$this->transformerManager->register();

Expand Down
12 changes: 10 additions & 2 deletions src/Core/Container/TransformerManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class TransformerManager implements ServiceInterface
private array $transformerContainers = [];

/**
* @var ?Closure(class-string<Transformer>): Transformer
* @var null|Closure(class-string<Transformer>): Transformer
*/
private ?Closure $dependencyInjectionHandler = null;

Expand Down Expand Up @@ -103,7 +103,10 @@ private function loadTransformer(mixed $transformerClassName): void

// Instantiate the transformer
if ($this->dependencyInjectionHandler) {
$transformerInstance = ($this->dependencyInjectionHandler)($transformerClassName);
$transformerInstance = ($this->dependencyInjectionHandler)(
$transformerClassName,
...($this->getAdditionalDependencyInjectionParams()),
);
} else {
try {
$transformerInstance = DI::make($transformerClassName);
Expand All @@ -130,6 +133,11 @@ private function loadTransformer(mixed $transformerClassName): void
$this->transformerContainers[$filePath] = $transformerContainer;
}

protected function getAdditionalDependencyInjectionParams(): array
{
return [];
}

// endregion

/**
Expand Down