Skip to content

Fixed "new cache states are not correctly merged" bug #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fixed "new cache states are not correctly merged" bug #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08ce750
Fixed "new cache states are not correctly merged" bug
WalterWoshid Nov 1, 2023
d9b1e22
Removed TODO section from README.md
WalterWoshid Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ composer require okapi/code-transformer
- [Limitations](#limitations)
- [How it works](#how-it-works)
- [Testing](#testing)
- [TODO](#todo)



Expand Down Expand Up @@ -332,18 +331,6 @@ Give a ⭐ if this project helped you!



## TODO

- Add support for Production/Development environments:
- Production: Cache will not be checked for updates (better performance)
- Development: Cache will be checked for updates (better debugging experience)

- Create a flowchart (WIP)

- Cache lifetime



## 🙏 Thanks

- Big thanks to [lisachenko](https://github.com/lisachenko) for their pioneering
Expand Down
2 changes: 1 addition & 1 deletion src/Core/Cache/CacheStateManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ private function saveCacheState(): void
// Create the cache state array
$cacheStateArray = array_map(
fn (CacheState $cacheState) => $cacheState->toArray(),
array_merge($this->newCacheState, $this->cacheState),
array_merge($this->cacheState, $this->newCacheState),
);

// Set the hash
Expand Down