Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to PayGroup + Bump dependencies + Remove grunt-sass/node-sass #755

Merged
merged 4 commits into from
Nov 2, 2019

Conversation

taoeffect
Copy link
Member

  • Greatly improves our tooling for SCSS. Now main css is saved to dist/assets/css/main.css, and component css included inside the component js files and injected when they're loaded
  • Bumped our dependencies and removed grunt-sass and node-sass (Closes Remove grunt-sass and node-sass as dependencies #638)
  • Moved classes out of _colors.scss into _typography.scss to prevent CSS duplication in components
  • Iterated a bit on PayGroup.vue, removing some no longer used code

Copy link
Contributor

@sandrina-p sandrina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't properly review the Pay Group page because I can't start the project. See the comments bellow.

.Gruntfile.babel.js Outdated Show resolved Hide resolved
.Gruntfile.babel.js Show resolved Hide resolved
backend/index.js Show resolved Hide resolved
.Gruntfile.babel.js Show resolved Hide resolved
frontend/assets/style/_typography.scss Show resolved Hide resolved
frontend/views/components/Chatroom/ChatMain.vue Outdated Show resolved Hide resolved
frontend/views/pages/PayGroup.vue Outdated Show resolved Hide resolved
frontend/views/pages/PayGroup.vue Outdated Show resolved Hide resolved
frontend/views/pages/PayGroup.vue Outdated Show resolved Hide resolved
frontend/views/pages/PayGroup.vue Show resolved Hide resolved
@sandrina-p sandrina-p merged commit babd47e into master Nov 2, 2019
@sandrina-p sandrina-p deleted the cash-payments-10 branch November 2, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove grunt-sass and node-sass as dependencies
2 participants