-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dependencies, added eslint, rollup, plus some fixes #521
Conversation
2eece61
to
a911206
Compare
- Removed no longer used dependencies - Added fully support for code-splitting and lazy loading of components (see example with route `/user-group`) - Replaced `standard` with `standard`-based `eslint` setup that catches a lot more - Deleted `frontend/_static` folder (next is moving `frontend/simple` into `frontend`) - Added `historical/` folder where potentially useful old code can be stored for future reference - Using `rollup-plugin-css-only` to extract component stylesheets out of the app bundle and into a separate `component.css` file - Updated a bunch of dependencies
4f1fac3
to
b447eb5
Compare
4b1f9ca
to
97d649d
Compare
frontend/main.js
Outdated
@@ -53,6 +53,8 @@ async function startApp () { | |||
new Vue({ | |||
router: router, | |||
components: { | |||
// Sidebar: await import('./views/containers/sidebar/Sidebar.vue'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code?
@@ -78,21 +78,24 @@ | |||
.fade-leave-to /* .fade-leave-active below version 2.1.8 */ { | |||
opacity: 0; | |||
} | |||
</style> | |||
<style scoped> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why this code is going to global css now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the scoped back in, but also have added a bunch of comments about doing this properly with transitions.js
(which currently has a poor implementation that isn't really being used), that's something that I hope you can improve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #529 to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Great work!
This PR
vueify
and switches us frombrowserify
to the more advanced (and more rigid)rollup
component.css
fileimport()
and shows an example of how to do that withUserGroup.vue
inrouter.js
frontend/simple
up one directory and placed all router links under/app
URL (Move the stuff in frontend/simple up one directory #526) in order to make it easier to serve the app using third-party toolsstandard
toeslint
witheslint-plugin-standard
frontend/_static
historical
under which old but potentially useful code can be keptbrowserslist
key inpackage.json
so thatasync/await
do not get transformed by babelI recommend viewing the diff with whitespace changes turned off.
TODO
rollup.watch
instead ofrollup.rollup
!Replacerollup-plugin-serve
withserve
, or better yet,just keep what we currently have with grunt and run rollup via grunt / grunt-execthat didn't work out too well. So now am thinking maybe I should try with browser-sync? Or maybe just switch to webpack...? Maybe leave it all for a future PR.Remove all browserify related dependencies and migrate any remaining stuff to rollup (for example, by usingscript2ify
withrollup-plugin-browserify-transform
eslint-config-standard
so that it lints.vue
files (instead of using standard directly, because it doesn't support that for some reason)Sidebar.vue
, and (2) that when I removed../../
from// @import "../../node_modules/bulma/sass/utilities/initial-variables";
(and all the other../../node_modules
), that I didn't break anything. Re-add the../../
if I did. Choose either thegrunt-sass
, or better yet (so that@import
can be called from components), removegrunt-sass
and use the bundler's sass plugin (whatever the equivalent for vueify/rollup/webpack is)