Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for zellij #30

Closed
hbiel opened this issue Jun 29, 2022 · 7 comments
Closed

add support for zellij #30

hbiel opened this issue Jun 29, 2022 · 7 comments

Comments

@hbiel
Copy link

hbiel commented Jun 29, 2022

Hey @ojroques!

First of all thank you for creating this plugin. I would love to make use of it in my configuration.

I'm using Zellij as my terminal multiplexer though and it seems to need a different sequence than e.g. tmux. Would you be able to look into this and add support for it?

Here is a sequence I found in their repository: https://github.com/zellij-org/zellij/blob/67d2673cae60954e8287c2a1f58a21a56e066afb/zellij-server/src/tab/clipboard.rs#L34
Unfortunately I don't know how to read and implement this sequence exactly myself.

Best Regards!

@ojroques
Copy link
Owner

Hello!

I read that in the config of Zelliji:

# Provide a command to execute when copying text. The text will be piped to
# the stdin of the program to perform the copy. This can be used with
# terminal emulators which do not support the OSC 52 ANSI control sequence
# that will be used by default if this option is not set.

(source)

So first does OSC52 work outside of Vim when you copy text in Zelliji? And what terminal emulator do you use?

@hbiel
Copy link
Author

hbiel commented Jun 30, 2022

Thank you for your quick response!

I'm on Windows and use Windows Terminal, mainly using a wsl distribution. This is how I'm copying text from Zellij so far:

  1. Select text via mouse
  2. On release of the button the message "Text copied to clipboard" gets printed
  3. I can paste the copied text in Windows

I didn't set any copy command in the configuration so I think OSC52 is used and working.

@ojroques
Copy link
Owner

ojroques commented Jul 1, 2022

So I've tried using the sequence from your link but it does not work. I suspect that Zelliji does not forward escape sequence from applications yet. There is a related issue already zellij-org/zellij#1199.

@hbiel
Copy link
Author

hbiel commented Jul 1, 2022

Ah, I see. I didn't know about this. Thanks for pointing it out.
Should this issue stay open then? Are there possible changes you need to make once Zellij supports forwarding?

@ojroques
Copy link
Owner

ojroques commented Jul 1, 2022

Yes it can stay open. I don't think any change will be necessary but we'll see.

@Winson-Huang
Copy link

After zellij-org/zellij#1644 this have been solved, I think this issue can be closed and shouldn't be opened in the first place :-(

@ojroques
Copy link
Owner

ojroques commented Jan 3, 2023

Great!

@ojroques ojroques closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants