forward OSC52 events #1644
Merged
forward OSC52 events #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsnif
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
This looks great, apologies for taking a few days to get to it.
Would have been nice to add a test, but given the nature of this change, we'll need to add some infrastructure to do so. I'm doing this elsewhere for some other mouse interaction stuff, so will add a test for this as well then.
Thanks for this!
|
I'm really excited about this! Thank you so much 😊 |
|
Well, thank you for this excellent piece of software. Apparently it's good enough that people use and care to improve it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1199