Open
Conversation
Implement 7 i18n tools for managing ABAP translations: - GetObjectTextsInLanguage, GetDataElementLabels, GetMessageClassTexts (read) - GetTextPoolInLanguage, CompareObjectLanguages (read) - WriteMessageClassTexts, WriteDataElementLabels (write, expert mode) Add OverrideLanguage field to RequestOptions and update buildURL() to support per-request sap-language override without affecting global config. Tool group "N" for selective disablement. 5 read-only tools in focused mode, all 7 in expert mode. Closes oisee#40 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous mock reused the same http.Response body reader, which gets exhausted after the first read. Use a funcMockClient that returns fresh responses and varies content based on sap-language query parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OverrideLanguagefield toRequestOptions+ minimal change tobuildURL()inhttp.go(3 lines)pkg/adt/i18n.go,internal/mcp/handlers_i18n.go,pkg/adt/i18n_test.go(6 tests)pkg/adt/http.go(OverrideLanguage support),pkg/adt/http_test.go,internal/mcp/server.go(tool group"N")Tools
GetObjectTextsInLanguageGetDataElementLabelsGetMessageClassTextsGetTextPoolInLanguageCompareObjectLanguagesWriteMessageClassTextsWriteDataElementLabelsKey design decision
Per-request language override via
OverrideLanguageinRequestOptions—buildURL()applies it after the globalsap-language, cleanly overriding withq.Set(). No changes to existing tool behavior.Test plan
go build ./...passesgo test ./...passes (6 new i18n tests + existing http_test updated)go vet ./...cleanCloses #40
🤖 Generated with Claude Code