Migrate EmptyParametersRule

oibot · Jan 28, 2019 · b3c399b · b3c399b
1 parent c1002d7
commit b3c399b
Showing 1 changed file with 5 additions and 22 deletions.
diff --git a/Source/SwiftLintFramework/Rules/Style/EmptyParametersRule.swift b/Source/SwiftLintFramework/Rules/Style/EmptyParametersRule.swift
@@ -1,7 +1,7 @@
 import Foundation
 import SourceKittenFramework
 
-public struct EmptyParametersRule: ConfigurationProviderRule, CorrectableRule, AutomaticTestableRule {
+public struct EmptyParametersRule: ConfigurationProviderRule, SubstitutionCorrectableRule, AutomaticTestableRule {
     public var configuration = SeverityConfiguration(.warning)
 
     public init() {}
@@ -35,14 +35,14 @@ public struct EmptyParametersRule: ConfigurationProviderRule, CorrectableRule, A
     )
 
     public func validate(file: File) -> [StyleViolation] {
-        return violationRanges(file: file).map {
+        return violationRanges(in: file).map {
             StyleViolation(ruleDescription: type(of: self).description,
                            severity: configuration.severity,
                            location: Location(file: file, characterOffset: $0.location))
         }
     }
 
-    private func violationRanges(file: File) -> [NSRange] {
+    public func violationRanges(in file: File) -> [NSRange] {
         let voidPattern = "\\(Void\\)"
         let pattern = voidPattern + "\\s*(throws\\s+)?->"
         let excludingPattern = "->\\s*" + pattern // excludes curried functions
@@ -55,24 +55,7 @@ public struct EmptyParametersRule: ConfigurationProviderRule, CorrectableRule, A
         }
     }
 
-    public func correct(file: File) -> [Correction] {
-        let violatingRanges = file.ruleEnabled(violatingRanges: violationRanges(file: file), for: self)
-        var correctedContents = file.contents
-        var adjustedLocations = [Int]()
-
-        for violatingRange in violatingRanges.reversed() {
-            if let indexRange = correctedContents.nsrangeToIndexRange(violatingRange) {
-                correctedContents = correctedContents
-                    .replacingCharacters(in: indexRange, with: "()")
-                adjustedLocations.insert(violatingRange.location, at: 0)
-            }
-        }
-
-        file.write(correctedContents)
-
-        return adjustedLocations.map {
-            Correction(ruleDescription: type(of: self).description,
-                       location: Location(file: file, characterOffset: $0))
-        }
+    public func substitution(for violationRange: NSRange, in file: File) -> (NSRange, String) {
+        return (violationRange, "()")
     }
 }