[client-app] Move private plugins into the client-app tree

.gitignore

@@ -8,20 +8,6 @@
 **/.arclint
 **/arclib
 
-##### Client Private Plugins (symlinked)
-**/client-app/src/error-logger-extensions
-**/client-app/src/nylas-private-*
-**/internal_packages/nylas-private-*
-**/internal_packages/activity-list
-**/internal_packages/composer-mail-merge
-**/internal_packages/composer-scheduler
-**/internal_packages/link-tracking
-**/internal_packages/open-tracking
-**/internal_packages/send-later
-**/internal_packages/send-reminders
-**/internal_packages/thread-sharing
-**/internal_packages/client-sync
-
 ##### Node modules
 node_modules
 !packages/client-app/spec/fixtures/packages/package-with-incompatible-native-module/node_modules

packages/client-app/build/Gruntfile.js

@@ -74,19 +74,16 @@ module.exports = (grunt) => {
       // The Windows electron-winstaller task must be run outside of grunt
     ]);
   } else if (grunt.option('platform') === 'darwin') {
-    const subTasks = process.env.SIGN_BUILD ? ["setup-mac-keychain"] : []
-    grunt.registerTask("build-client", subTasks.concat([
+    grunt.registerTask("build-client", [
       "package",
       "create-mac-zip",
       "create-mac-dmg",
-    ]));
+    ]);
   } else if (grunt.option('platform') === 'linux') {
     grunt.registerTask("build-client", [
       "package",
       "create-deb-installer",
       "create-rpm-installer",
     ]);
   }
-
-  grunt.registerTask("upload-client", ["upload"])
 }

packages/client-app/build/tasks/package-task.js

@@ -231,12 +231,6 @@ module.exports = (grunt) => {
       'out': grunt.config('outputDir'),
       'overwrite': true,
       'prune': true,
-      /**
-       * This will automatically look for the identity in the keychain. It
-       * runs the `security find-identity` command. Note that
-       * setup-mac-keychain-task needs to be run first
-       */
-      'osx-sign': !!process.env.SIGN_BUILD,
       'win32metadata': {
         CompanyName: 'Nylas, Inc.',
         FileDescription: 'Nylas Mail',