fix: #267, fix requiredDeviceType and hdc deviceType detect#268
Merged
Groupguanfang merged 2 commits intonextfrom Feb 20, 2026
Merged
fix: #267, fix requiredDeviceType and hdc deviceType detect#268Groupguanfang merged 2 commits intonextfrom
Groupguanfang merged 2 commits intonextfrom
Conversation
🦋 Changeset detectedLatest commit: 2d8d3c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #267 by adjusting the language-server default TypeScript/ETS compiler options and refining VSCode task behavior/documentation around hvigor-assemble-hap device type handling.
Changes:
- Update
hvigor-assemble-haptask argument construction to makerequiredDeviceTypeconditional and attempt device type detection viahdc. - Remove
composite: truefrom the language-server’s merged default compiler options. - Update VSCode extension README to add usage/FAQ section and document supported tasks; add a changeset for the language-server version bump.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/vscode/src/tasks/hvigor-assemble-hap.ts | Makes requiredDeviceType flag conditional and changes how device type is detected from hdc. |
| packages/vscode/README.md | Adds usage/FAQ section and documents task support. |
| packages/language-server/src/classes/config-manager.ts | Removes composite: true from default merged compiler options. |
| .changeset/dry-months-post.md | Declares a release entry for the language-server change (fix #267). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #267