Skip to content

Commit

Permalink
differentiate class and insance methods in ReturnCode class for nativ…
Browse files Browse the repository at this point in the history
…e platforms
  • Loading branch information
tanersener committed Nov 8, 2021
1 parent b142442 commit eee8d85
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ public static void getMediaInformationExecute(final MediaInformationSession medi
final int returnCodeValue = nativeFFprobeExecute(mediaInformationSession.getSessionId(), mediaInformationSession.getArguments());
final ReturnCode returnCode = new ReturnCode(returnCodeValue);
mediaInformationSession.complete(returnCode);
if (returnCode.isSuccess()) {
if (returnCode.isValueSuccess()) {
MediaInformation mediaInformation = MediaInformationJsonParser.fromWithError(mediaInformationSession.getAllLogsAsString(waitTimeout));
mediaInformationSession.setMediaInformation(mediaInformation);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ public int getValue() {
return value;
}

public boolean isSuccess() {
public boolean isValueSuccess() {
return (value == SUCCESS);
}

public boolean isError() {
public boolean isValueError() {
return ((value != SUCCESS) && (value != CANCEL));
}

public boolean isCancel() {
public boolean isValueCancel() {
return (value == CANCEL);
}

Expand Down
6 changes: 3 additions & 3 deletions apple/src/ReturnCode.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ typedef NS_ENUM(NSUInteger, ReturnCodeEnum) {

- (int)getValue;

- (BOOL)isSuccess;
- (BOOL)isValueSuccess;

- (BOOL)isError;
- (BOOL)isValueError;

- (BOOL)isCancel;
- (BOOL)isValueCancel;

@end

Expand Down
6 changes: 3 additions & 3 deletions apple/src/ReturnCode.m
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ - (int)getValue {
return _value;
}

- (BOOL)isSuccess {
- (BOOL)isValueSuccess {
return (_value == ReturnCodeSuccess);
}

- (BOOL)isError {
- (BOOL)isValueError {
return ((_value != ReturnCodeSuccess) && (_value != ReturnCodeCancel));
}

- (BOOL)isCancel {
- (BOOL)isValueCancel {
return (_value == ReturnCodeCancel);
}

Expand Down

0 comments on commit eee8d85

Please sign in to comment.