Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min date for discharge #9083

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix min date for discharge #9083

merged 1 commit into from
Nov 11, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Nov 11, 2024 •
edited by coderabbitai bot
Loading

Proposed Changes

  • Fixes #issue_number
  • Change 1
  • Change 2
  • More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Enhanced validation for discharge and death dates, ensuring they are appropriately set relative to the encounter date.
    • Conditional rendering of the "Confirmed By" field, required only when the discharge reason is "Expired."

  • Bug Fixes

    • Improved error handling for discharge reason validation and associated fields.

  • User Experience Improvements

    • Dynamic adjustments to the discharge form based on selected discharge reasons, streamlining the process for users.

@shivankacker shivankacker requested a review from a team as a code owner November 11, 2024 12:54
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The DischargeModal component in src/components/Facility/DischargeModal.tsx has been updated to enhance validation logic and date handling for discharge and death scenarios. Changes include adjusting the minimum selectable date for discharge and death dates, refining validation checks for the "Expired" discharge reason, and improving error handling. Conditional rendering has been added for the "Confirmed By" field, and the handleFacilitySelect function has been modified to update relevant state fields based on the selected facility.

Changes

File Path Change Summary
src/components/Facility/DischargeModal.tsx Updated validation logic for discharge and death dates, refined checks for "Expired" reason, improved error handling, added conditional rendering for "Confirmed By" field, and modified handleFacilitySelect function.

Possibly related PRs

Suggested labels

urgent, needs review, tested, P1

Suggested reviewers

  • rithviknishad

Poem

🐇 In the modal where discharges play,
Dates are checked in a new way.
With reasons clear and fields aligned,
A smoother path for all to find.
So hop along, let errors cease,
In this update, we find our peace! 🌼

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

In case the error is due to missing dependencies, please add them to the package.json file. In case of unrecoverable error (e.g. due to private dependencies), please disable the tool within CodeRabbit configuration.

src/components/Facility/DischargeModal.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.json': Cannot find module '@typescript-eslint/parser'
Require stack:

  • /.eslintrc.json
    at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
    at Function.resolve (node:internal/modules/helpers:145:19)
    at Object.resolve (/git/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46)
    at ConfigArrayFactory._loadParser (/home/jailuser/git/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/home/jailuser/git/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43)
    at _normalizeObjectConfigDataBody.next ()
    at ConfigArrayFactory._normalizeObjectConfigData (/home/jailuser/git/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
    at _normalizeObjectConfigData.next ()
    at ConfigArrayFactory.loadInDirectory (/home/jailuser/git/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28)
    at CascadingConfigArrayFactory._loadConfigInAncestors (/home/jailuser/git/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 7c378fe
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6731fe8fdb8e04000827b593
😎 Deploy Preview https://deploy-preview-9083--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivankacker shivankacker changed the title Fixed Discharge Date Fix min date for discharge Nov 11, 2024
@shivankacker shivankacker self-assigned this Nov 11, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c378fe
Status: ✅  Deploy successful!
Preview URL: https://d917a481.care-fe.pages.dev
Branch Preview URL: https://discharge-date-fix-dev.care-fe.pages.dev

View logs

@rithviknishad rithviknishad merged commit c6de776 into develop Nov 11, 2024
22 of 24 checks passed
@rithviknishad rithviknishad deleted the discharge-date-fix-dev branch November 11, 2024 12:56
@github-actions GitHub Actions
Copy link

@shivankacker @shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

This was referenced Nov 12, 2024
Open
Merged
Merged
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees

@shivankacker shivankacker

Labels
None yet
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivankacker @rithviknishad