Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lodash imports to be tree shakable #8962

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Oct 29, 2024

Proposed Changes

Changes

Before:

image image

After:

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner October 29, 2024 14:17
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit e16fd68
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6720ee6a985c4f00084b1976
😎 Deploy Preview https://deploy-preview-8962--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Oct 29, 2024

CARE    Run #3768

Run Properties:  status check passed Passed #3768  •  git commit e16fd682fa: update lodash imports to be tree shakable
Project CARE
Branch Review sainak/cleanup-lodash-imports
Run status status check passed Passed #3768
Run duration 03m 06s
Commit git commit e16fd682fa: update lodash imports to be tree shakable
Committer Aakash Singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

Copy link

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: e16fd68
Status:🚫  Build failed.

View logs

@khavinshankar khavinshankar added reviewed reviewed by a core member and removed needs review labels Oct 30, 2024
@khavinshankar khavinshankar merged commit c9343d5 into develop Oct 30, 2024
32 of 33 checks passed
@khavinshankar khavinshankar deleted the sainak/cleanup-lodash-imports branch October 30, 2024 04:23
Copy link

@sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@sainak sainak self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants