enable livekit plugin; fixed dockerfile #8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithviknishad
changed the base branch from
rithviknishad/enable-livekit-plugin
to
develop
rithviknishad
approved these changes
Oct 24, 2024
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
changed the title
Replaced git-get with native git.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Added NPM package simple-git to perform git clone.
This reverts commit c6d53ac.
rithviknishad
approved these changes
Oct 24, 2024
|
@rithviknishad @tellmeY18 @tellmeY18 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
noufalrahim
pushed a commit
to noufalrahim/care_fe
that referenced
this pull request
Oct 24, 2024
Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm install and npm setup are being run during the npm build script. script setup care apps is downloading the plugins as a tar.gz and they don't have the .git directory inside, so while rerun the script fails to git pull the plugin repo since remote and other git info is missing.
removing the redundant install / setup scripts appears to be a temporary fix for the problem, and the image is built succesfully.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist