Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Misaligned text when there's no data #8807

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Fixed Misaligned text when there's no data #8807

merged 7 commits into from
Oct 22, 2024

Conversation

nithish1018
Copy link
Contributor

Proposed Changes

This is how it looks now:

image
image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nithish1018 nithish1018 requested a review from a team as a code owner October 16, 2024 17:09
@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 7acf200
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67168d41bdab330008ef37e3
😎 Deploy Preview https://deploy-preview-8807--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish
bodhish requested changes Oct 17, 2024
View reviewed changes
src/Components/Shifting/ListView.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@rithviknishad rithviknishad mentioned this pull request Oct 17, 2024
Merged
6 tasks
@nihal467
Copy link
Member

LGTM

bodhish
bodhish approved these changes Oct 21, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 21, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @nithish1018,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 21, 2024
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Oct 21, 2024
@khavinshankar khavinshankar merged commit 2b8470c into ohcnetwork:develop Oct 22, 2024
23 checks passed
@github-actions GitHub Actions
Copy link

@nithish1018 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak left review comments

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish bodhish approved these changes

Assignees
No one assigned
Labels
needs review needs testing tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misaligned Text - "No patients to show" in List View of Shifting Page
6 participants
@nithish1018 @nihal467 @bodhish @rithviknishad @khavinshankar @sainak