Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Spokes on Facility Create Page #8730

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 7, 2024

Proposed Changes

Following the conversation on slack, hiding spokes heading on facility creation page.

Before

image

After

image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 7, 2024 04:49
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5a7a1f9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/67036ceabc130d0008d50513
😎 Deploy Preview https://deploy-preview-8730--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar
Copy link
Member

@Jacobjeevan can you please fix the failing cypress tests

@khavinshankar khavinshankar added the cypress failed pull request with cypress test failure label Oct 7, 2024
@Jacobjeevan
Copy link
Contributor Author

@khavinshankar Reran the failing one and it's passing 👍

Note: Noticed the same test failing in https://github.com/ohcnetwork/care_fe/actions/runs/11208536036/job/31152363494, but worked later.

@Jacobjeevan Jacobjeevan added cypress passed and removed cypress failed pull request with cypress test failure labels Oct 7, 2024
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Oct 8, 2024

LGTM

@bodhish bodhish merged commit 207365a into ohcnetwork:develop Oct 9, 2024
30 checks passed
Copy link

github-actions bot commented Oct 9, 2024

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@Jacobjeevan Jacobjeevan deleted the issues/8624-facilitySpoke branch October 9, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants