Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Infinite Loading State When Notification is blocked or granted #8659

Merged

Conversation

shauryag2002
Copy link
Contributor

@shauryag2002 shauryag2002 commented Sep 28, 2024

Proposed Changes

Videos of changes:

notify_block.mp4
Notify_grant.mp4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shauryag2002 shauryag2002 requested a review from a team as a code owner September 28, 2024 20:56
Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit b6ca0d1
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f86d9c169a9e0008250219
😎 Deploy Preview https://deploy-preview-8659--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f9d78f4 into ohcnetwork:develop Oct 1, 2024
36 checks passed
Copy link

github-actions bot commented Oct 1, 2024

@shauryag2002 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Loading State When Notification Permission is Blocked or granted
4 participants