Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show validation error message on facility cover image upload (#8625) #8639

Merged

Conversation

syedfardeenjeelani
Copy link
Contributor

Proposed Changes

Video Demo:
https://github.com/user-attachments/assets/f0c8d680-8885-4856-a2ee-77fbebd27964

@ohcnetwork/care-fe-code-reviewers
@nihal467

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews.
  • Completion of QA.

@syedfardeenjeelani syedfardeenjeelani requested a review from a team as a code owner September 26, 2024 13:22
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 9ebaf2d
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f68e367f4400000824e3de
😎 Deploy Preview https://deploy-preview-8639--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead show the error from the backend as is as mentioned in issue comment instead of duplicating the validations and checks from client too?

@syedfardeenjeelani
Copy link
Contributor Author

Can we instead show the error from the backend as is as mentioned in issue comment instead of duplicating the validations and checks from client too?

sure

@syedfardeenjeelani
Copy link
Contributor Author

syedfardeenjeelani commented Sep 26, 2024

Can we instead show the error from the backend as is as mentioned in issue comment instead of duplicating the validations and checks from client too?

here is the demo of the video

Recording.2024-09-26.195959.1.mp4

@syedfardeenjeelani
Copy link
Contributor Author

@rithviknishad how to fix these errors

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b6c9577 into ohcnetwork:develop Sep 27, 2024
23 checks passed
Copy link

@syedfardeenjeelani Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show validation error message on facility cover image upload
4 participants