-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix/#15092 calendar today button #15143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix/#15092 calendar today button #15143
Conversation
|
WalkthroughAdded the Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Conflicts have been detected against the base branch. Please merge the base branch into your branch.
|
🚀 Preview Deployment Ready!🔗 Preview URL: https://pr-15143.care-preview-a7w.pages.dev 📱 Mobile Access: This preview will be automatically updated when you push new commits to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Line 191: The package.json currently includes an unused dependency "wrangler":
"^4.59.1"; remove this entry from the dependencies/devDependencies section so
the PR stays focused and avoids adding unrelated tooling, then run your package
manager's install command (npm/yarn/pnpm) to update lockfiles and ensure CI
passes; reference the "wrangler" entry in package.json when making the change.
📜 Review details
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
🧰 Additional context used
📓 Path-based instructions (3)
package.json
📄 CodeRabbit inference engine (.github/instructions/config-files.instructions.md)
Maintain
package.jsonas the primary dependency and script configuration
Files:
package.json
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Use 2-space indentation
Files:
package.json
**/*.{ts,tsx,js,jsx,json,css,scss,html}
📄 CodeRabbit inference engine (AGENTS.md)
Use 2-space indentation
Files:
package.json
🧠 Learnings (2)
📓 Common learnings
Learnt from: AdityaJ2305
Repo: ohcnetwork/care_fe PR: 13197
File: src/pages/Facility/settings/observationDefinition/ObservationDefinitionForm.tsx:470-495
Timestamp: 2025-09-16T20:46:59.537Z
Learning: In PR `#13197`, AdityaJ2305 indicated that aria-invalid and ref forwarding improvements for ValueSetSelect components can be deferred to a separate PR, considering them not critical for the current focus/scroll fix implementation.
Learnt from: AdityaJ2305
Repo: ohcnetwork/care_fe PR: 11342
File: src/pages/Facility/settings/devices/components/DeviceForm.tsx:330-336
Timestamp: 2025-03-26T12:19:38.781Z
Learning: The PR objectives have been updated to create a new DatePickerInput component that combines absolute date picking (using native input type="date") and relative date picking capabilities, rather than simply replacing custom date pickers with native inputs. The absolute date picker is implemented using native HTML input elements, while a separate relative date picker is included for selecting dates relative to the current date.
📚 Learning: 2025-11-25T13:51:07.680Z
Learnt from: CR
Repo: ohcnetwork/care_fe PR: 0
File: .github/instructions/config-files.instructions.md:0-0
Timestamp: 2025-11-25T13:51:07.680Z
Learning: Applies to package.json : Maintain `package.json` as the primary dependency and script configuration
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: deploy-preview
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
AdityaJ2305
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Attach issue with PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discard changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discard changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
5bca243 to
ee37292
Compare
ee37292 to
e598efe
Compare
e598efe to
069801c
Compare
|
@Abhinandan-basotra avoid force pushes unless absolutely necessary. |
This is my first PR. So, I don't have much experience about that. I was getting many conflicts. So, I did this. The current changes is already present in the latest commit and I'll stick to normal commits/pushes from here. |
Proposed Changes
The Calendar component was already expecting a setSelectedDate prop internally, but it wasn’t being passed from this Schedule component. I passed setSelectedDate to the Calendar component.
Fixes #15092
Tagging: @ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.