cleanup: Add missing requires.

This is a port of the internal changes: cl/329816039 Change-Id: If162e80e107ef7dc40956d6f4160d24f6d50858d
ogheorghies · Sep 14, 2020 · 67a49d4 · 67a49d4
1 parent 5137898
commit 67a49d4
Show file tree

Hide file tree

Showing 18 changed files with 26 additions and 4 deletions.
diff --git a/ui/ad_counter.js b/ui/ad_counter.js
@@ -15,6 +15,7 @@ goog.require('shaka.ui.Localization');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.Timer');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/ad_position.js b/ui/ad_position.js
@@ -13,6 +13,7 @@ goog.require('shaka.ui.Locales');
 goog.require('shaka.ui.Localization');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/audio_language_selection.js b/ui/audio_language_selection.js
@@ -16,6 +16,7 @@ goog.require('shaka.ui.OverflowMenu');
 goog.require('shaka.ui.SettingsMenu');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.FakeEvent');
+goog.requireType('shaka.ui.Controls');
 
 /**
  * @extends {shaka.ui.SettingsMenu}

diff --git a/ui/big_play_button.js b/ui/big_play_button.js
@@ -8,6 +8,7 @@
 goog.provide('shaka.ui.BigPlayButton');
 
 goog.require('shaka.ui.PlayButton');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/cast_button.js b/ui/cast_button.js
@@ -17,6 +17,8 @@ goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.Error');
 goog.require('shaka.util.FakeEvent');
+goog.requireType('shaka.cast.CastProxy');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/controls.js b/ui/controls.js
@@ -11,6 +11,7 @@ goog.provide('shaka.ui.ControlsPanel');
 goog.require('goog.asserts');
 goog.require('shaka.Deprecate');
 goog.require('shaka.ads.AdManager');
+goog.require('shaka.cast.CastProxy');
 goog.require('shaka.log');
 goog.require('shaka.ui.AdCounter');
 goog.require('shaka.ui.AdPosition');
@@ -19,13 +20,13 @@ goog.require('shaka.ui.Locales');
 goog.require('shaka.ui.Localization');
 goog.require('shaka.ui.SeekBar');
 goog.require('shaka.ui.Utils');
-goog.require('shaka.cast.CastProxy');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.EventManager');
 goog.require('shaka.util.FakeEvent');
 goog.require('shaka.util.FakeEventTarget');
 goog.require('shaka.util.IDestroyable');
 goog.require('shaka.util.Timer');
+goog.requireType('shaka.Player');
 
 
 /**
@@ -74,10 +75,10 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
     /** @private {shaka.extern.IAdManager} */
     this.adManager_ = this.player_.getAdManager();
 
-    /** @private {shaka.extern.IAd} */
+    /** @private {?shaka.extern.IAd} */
     this.ad_ = null;
 
-    /** @private {shaka.ui.SeekBar} */
+    /** @private {?shaka.ui.SeekBar} */
     this.seekBar_ = null;
 
     /** @private {boolean} */

diff --git a/ui/element.js b/ui/element.js
@@ -9,6 +9,9 @@ goog.provide('shaka.ui.Element');
 
 goog.require('shaka.ads.AdManager');
 goog.require('shaka.util.EventManager');
+goog.requireType('shaka.Player');
+goog.requireType('shaka.ui.Controls');
+goog.requireType('shaka.ui.Localization');
 
 
 /**
@@ -65,7 +68,7 @@ shaka.ui.Element = class {
     this.adManager = this.player.getAdManager();
 
     /**
-     * @protected {shaka.extern.IAd}
+     * @protected {?shaka.extern.IAd}
      * @exportInterface
      */
     this.ad = null;

diff --git a/ui/language_utils.js b/ui/language_utils.js
@@ -13,6 +13,7 @@ goog.require('shaka.ui.Locales');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.LanguageUtils');
+goog.requireType('shaka.ui.Localization');
 
 
 shaka.ui.LanguageUtils = class {

diff --git a/ui/loop_button.js b/ui/loop_button.js
@@ -15,6 +15,7 @@ goog.require('shaka.ui.Localization');
 goog.require('shaka.ui.OverflowMenu');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.Timer');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/pip_button.js b/ui/pip_button.js
@@ -16,6 +16,7 @@ goog.require('shaka.ui.OverflowMenu');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.FakeEvent');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/play_button.js b/ui/play_button.js
@@ -13,6 +13,7 @@ goog.require('shaka.ui.Element');
 goog.require('shaka.ui.Locales');
 goog.require('shaka.ui.Localization');
 goog.require('shaka.util.Dom');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/playback_rate_selection.js b/ui/playback_rate_selection.js
@@ -15,6 +15,7 @@ goog.require('shaka.ui.OverflowMenu');
 goog.require('shaka.ui.SettingsMenu');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
+goog.requireType('shaka.ui.Controls');
 
 /**
  * @extends {shaka.ui.SettingsMenu}

diff --git a/ui/range_element.js b/ui/range_element.js
@@ -9,6 +9,7 @@ goog.provide('shaka.ui.RangeElement');
 
 goog.require('shaka.ui.Element');
 goog.require('shaka.util.Dom');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/resolution_selection.js b/ui/resolution_selection.js
@@ -17,6 +17,7 @@ goog.require('shaka.ui.SettingsMenu');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.FakeEvent');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/seek_bar.js b/ui/seek_bar.js
@@ -15,6 +15,8 @@ goog.require('shaka.ui.RangeElement');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.Timer');
+goog.requireType('shaka.ads.CuePoint');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/settings_menu.js b/ui/settings_menu.js
@@ -12,6 +12,7 @@ goog.require('shaka.ui.Enums');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.FakeEvent');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/skip_ad_button.js b/ui/skip_ad_button.js
@@ -15,6 +15,7 @@ goog.require('shaka.ui.Localization');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.Timer');
+goog.requireType('shaka.ui.Controls');
 
 
 /**

diff --git a/ui/text_selection.js b/ui/text_selection.js
@@ -17,6 +17,7 @@ goog.require('shaka.ui.SettingsMenu');
 goog.require('shaka.ui.Utils');
 goog.require('shaka.util.Dom');
 goog.require('shaka.util.FakeEvent');
+goog.requireType('shaka.ui.Controls');
 
 
 /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,7 @@ @@
     goog.provide('shaka.ui.BigPlayButton');
     goog.require('shaka.ui.PlayButton');
+    goog.requireType('shaka.ui.Controls');
     /**
@@ Expand Down @@