feat: support patternParameters and typed additionalParameters #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support the ability to specify either:
...or...
I've created a test case here that utilizes both
additionalProperties
andpatternProperties
and succeeds in creating the associated codegen. Most notably, the generated schema file (internal/integration/test_additionalpropertiespatternproperties/oas_schemas_gen.go
) seems to be look good which (at least, to me) indicates things are behaving as expected.I'm hoping this is the correct approach here. If not, I'd be happy to start a discussion on best approaches to facilitate supporting
additionalProperties
andpatternProperties
.As an aside: it seems like based on prior discussions that there has been hesitation in supporting
additionalProperties: true
. As such, this PR does not aim to support it.