feat(ogen): defer recording error metric #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the ErrorHandler will run before the error metric is recorded. This is also in line when when the other server request metrics are recorded.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 73.90% 73.91% +0.01%
==========================================
Files 189 189
Lines 12730 12730
==========================================
+ Hits 9408 9410 +2
+ Misses 2787 2786 -1
+ Partials 535 534 -1 ☔ View full report in Codecov by Sentry. |
ernado
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other server request metrics are already deferred and recorded after the
ErrorHandleris called. This change ensures that metrics attributes added from within a customErrorHandlerwill also be used for the 'ogen.server.errors_count' metric.