Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): improve discriminator inference error reporting #1188

Merged

Conversation

tdakkota
Copy link
Member

For #1185

@tdakkota tdakkota force-pushed the feat/improve-discriminator-inference-error branch from 8acab2e to 4510e73 Compare February 26, 2024 12:28
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.84%. Comparing base (8bf8791) to head (6961361).
Report is 1 commits behind head on main.

Files Patch % Lines
gen/schema_gen_sum.go 93.33% 1 Missing and 1 partial ⚠️
gen/errors.go 88.88% 1 Missing ⚠️
location/error.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   73.78%   73.84%   +0.05%     
==========================================
  Files         188      188              
  Lines       12661    12692      +31     
==========================================
+ Hits         9342     9372      +30     
- Misses       2785     2786       +1     
  Partials      534      534              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota marked this pull request as ready for review February 28, 2024 09:57
@ernado ernado merged commit 257e48e into ogen-go:main Feb 28, 2024
14 checks passed
@tdakkota tdakkota deleted the feat/improve-discriminator-inference-error branch February 28, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants