Skip to content

Commit

Permalink
🔨 Suppressible CONFIGURATION_EMBEDDING warning (MarlinFirmware#23545)
Browse files Browse the repository at this point in the history
  • Loading branch information
thisiskeithb authored and Omkar Dhekne committed Mar 25, 2024
1 parent a746b41 commit 820dd8e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Marlin/src/inc/Warnings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -548,11 +548,11 @@
//
// Warn users of potential endstop/DIAG pin conflicts to prevent homing issues when not using sensorless homing
//
#if NONE(USE_SENSORLESS, DIAG_JUMPERS_REMOVED)
#if ENABLED(USES_DIAG_JUMPERS)
#if !USE_SENSORLESS
#if ENABLED(USES_DIAG_JUMPERS) && DISABLED(DIAG_JUMPERS_REMOVED)
#warning "Motherboard DIAG jumpers must be removed when SENSORLESS_HOMING is disabled. (Define DIAG_JUMPERS_REMOVED to suppress this warning.)"
#elif ENABLED(USES_DIAG_PINS)
#warning "Driver DIAG pins must be physically removed unless SENSORLESS_HOMING is enabled. (See https://bit.ly/2ZPRlt0) (Define DIAG_JUMPERS_REMOVED to suppress this warning.)"
#elif ENABLED(USES_DIAG_PINS) && DISABLED(DIAG_PINS_REMOVED)
#warning "Driver DIAG pins must be physically removed unless SENSORLESS_HOMING is enabled. (See https://bit.ly/2ZPRlt0) (Define DIAG_PINS_REMOVED to suppress this warning.)"
#endif
#endif

Expand Down
4 changes: 3 additions & 1 deletion buildroot/share/PlatformIO/scripts/signature.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ def compute_build_signature(env):

# Generate a C source file for storing this array
with open('Marlin/src/mczip.h','wb') as result_file:
result_file.write(b'#warning "Generated file \'mc.zip\' is embedded"\n')
result_file.write(b'#ifndef NO_CONFIGURATION_EMBEDDING_WARNING\n')
result_file.write(b' #warning "Generated file \'mc.zip\' is embedded (Define NO_CONFIGURATION_EMBEDDING_WARNING to suppress this warning.)"\n')
result_file.write(b'#endif\n')
result_file.write(b'const unsigned char mc_zip[] PROGMEM = {\n ')
count = 0
for b in open(os.path.join(build_dir, 'mc.zip'), 'rb').read():
Expand Down

0 comments on commit 820dd8e

Please sign in to comment.