[v2.6.x] prov/efa: fix global device count corruption in unit test#12592
Open
jiaxiyan wants to merge 1 commit into
Open
[v2.6.x] prov/efa: fix global device count corruption in unit test#12592jiaxiyan wants to merge 1 commit into
jiaxiyan wants to merge 1 commit into
Conversation
test_efa_device_construct_error_handling passed &g_efa_selected_device_cnt to ibv_get_device_list(), which overwrites it with the total number of IBV devices (including non-EFA devices). On hosts with mixed device types like p6b200, this inflates the count beyond the number of initialized entries in g_efa_selected_device_list and causes subsequent unit tests to fail. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com> (cherry picked from commit f1ee984)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_efa_device_construct_error_handling passed &g_efa_selected_device_cnt to ibv_get_device_list(), which overwrites it with the total number of IBV devices (including non-EFA devices). On hosts with mixed device types like p6b200, this inflates the count beyond the number of initialized entries in g_efa_selected_device_list and causes subsequent unit tests to fail.
(cherry picked from commit f1ee984)