fabtests/efa: guard fi_efa_rma_bw build on FI_EFA_WR_HIGH_PPS#12291
Open
shijin-aws wants to merge 1 commit into
Open
fabtests/efa: guard fi_efa_rma_bw build on FI_EFA_WR_HIGH_PPS#12291shijin-aws wants to merge 1 commit into
shijin-aws wants to merge 1 commit into
Conversation
fi_efa_rma_bw uses FI_EFA_WR_HIGH_PPS from rdma/fi_ext_efa.h. Only build the test when the symbol is present in the installed libfabric headers. Add AC_CHECK_DECL for FI_EFA_WR_HIGH_PPS in prov/efa/configure.m4 and wrap the binary target with the resulting HAVE_FI_EFA_WR_HIGH_PPS conditional in Makefile.include. Move the m4_include of prov/efa/configure.m4 in configure.ac to after --with-libfabric sets CPPFLAGS, so that header checks against the libfabric install tree work correctly. Signed-off-by: Shi Jin <sjina@amazon.com>
Contributor
Author
|
@ooststep can u test if this pr works for you ? |
j-xiong
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fi_efa_rma_bw uses FI_EFA_WR_HIGH_PPS from rdma/fi_ext_efa.h. Only build the test when the symbol is present in the installed libfabric headers.
Add AC_CHECK_DECL for FI_EFA_WR_HIGH_PPS in prov/efa/configure.m4 and wrap the binary target with the resulting HAVE_FI_EFA_WR_HIGH_PPS conditional in Makefile.include.
Move the m4_include of prov/efa/configure.m4 in configure.ac to after --with-libfabric sets CPPFLAGS, so that header checks against the libfabric install tree work correctly.