[v2.4.x] common: fix byte order of AF_IB ofi_addr_set_port#12272
Open
ooststep wants to merge 1 commit into
Open
[v2.4.x] common: fix byte order of AF_IB ofi_addr_set_port#12272ooststep wants to merge 1 commit into
ooststep wants to merge 1 commit into
Conversation
Contributor
|
bot:aws:retest |
The implementation of ofi_addr_get_port and ofi_addr_set_port did not allow for a succsessful round-trip of the sib_sid, which means users of these functions could not properly store and retrieve port information in a sockaddr. original port information could not be recreated and instead would get a byte flipped port. instead, construct a host-ordered sid and then convert ordering on the full value Signed-off-by: Stephen Oost <stephen.oost@intel.com> (cherry picked from commit 487707c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of ofi_addr_get_port and ofi_addr_set_port did not allow for a succsessful round-trip of the sib_sid, which means users of these functions could not properly store and retrieve port information in a sockaddr. original port information could not be recreated and instead would get a byte flipped port.
instead, construct a host-ordered sid and then convert ordering on the full value
(cherry picked from commit 487707c)