Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds auction error/debug event for analytics adapters to subscribe to #1

Merged
merged 4 commits into from
Aug 6, 2020
Merged

Conversation

patmmccann
Copy link

Suggested addition to prebid#5563

@ofirpaBrowsi ofirpaBrowsi merged commit bad8bf8 into ofirpaBrowsi:master Aug 6, 2020
@ofirpaBrowsi
Copy link
Owner

Hi @patmmccann ,
After merging there are some analytics failing tests, please check them.

@patmmccann
Copy link
Author

patmmccann commented Aug 6, 2020

I see sigmoid and prebidanalyticsmanager tests are causing errors and should be expecting 7 events after this change instead of 5 or 6. Does it make sense to just change those to 7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants