enable dynamic renormalization in updateWDL.sh #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest commit to this PR fixes #156. |
|
Can we have the grep be completely source file independent? I.e moving the constant around would break the current code? |
|
I think to avoid false positives, the current way is best. We can make it more general the next time the constant is moved around. (I am running the update script every day, so would spot when things go wrong next time.) Soon-ish the constant will disappear from SF code, once we switch to dynamic rescaling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the update script for the future, when official-stockfish/Stockfish#4920 will be merged into SF.
Some comments:
NormalizeToPawnValuenot being present insrc/uci.hfor SF revisions that do the dynamic eval rescaling. Edit: It now relies onconst in NormalizeToPawnValuenot being present insrc/uci.handconstexpr int NormalizeToPawnValuenot being present insrc/uci.cpp.NormalizeToPawnValueis computed on the fly, by summing the coefficients inas. The final sum is rounded, so that after merging use round not trunc for NormalizeToPawnValue #136 this will be consistent with the python script. Note also that for un-doing the dynamic rescaling, the valueNormalizeToPawnValueserves only a cosmetic purpose now. It is used at the end of the update script to indicate to the user if that value has changed from SF to the new model, or not.--firstrevand--lastrevit allows for extracting the newly fittedNormalizeToPawnValuefor both static and dynamic renormalization revisions of SF. This may be useful when adapting WIP: update a range of commits #119For as long as official-stockfish/Stockfish#4920 is not merged into SF, this PR is nonfunctional. Once that PR is merged, the update script needs to be pointed to that new commit in
default_firstrev, and it should then seamlessly work for the dynamic eval rescalings.