Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation Correction History #5617

Conversation

OmerFarukTutkun
Copy link
Contributor

@OmerFarukTutkun OmerFarukTutkun commented Oct 4, 2024

Continuation correction history uses last 2 move to correct static eval.

ContCorrHist first introduced by @martinnovaak in Motor(martinnovaak/motor#162).
Earlier ideas using last move to correct eval is introduced by @MinusKelvin in Ice4(MinusKelvin/ice4@45daf7d)

Passed STC:

LLR: 2.96 (-2.94,2.94) <0.00,2.00>
Total: 310144 W: 81267 L: 80538 D: 148339
Ptnml(0-2): 1160, 36607, 78834, 37286, 1185
https://tests.stockfishchess.org/tests/view/66f96cbc86d5ee47d953b7f7

Passed LTC:

LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 97470 W: 24892 L: 24447 D: 48131
Ptnml(0-2): 63, 10631, 26915, 11050, 76
https://tests.stockfishchess.org/tests/view/66fd59bc86d5ee47d953b9ea

bench 1143382

Copy link

github-actions bot commented Oct 4, 2024

clang-format 18 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/noble/clang-format-18.

(execution 11204194343 / attempt 1)

@FauziAkram
Copy link
Contributor

Congrats!
Remember to add your name in the AUTHORS list.

AUTHORS Outdated Show resolved Hide resolved
@Disservin
Copy link
Member

ci fails because of

types.h:387: constexpr Stockfish::Square Stockfish::Move::to_sq() const: Assertion `is_ok()' failed.

@OmerFarukTutkun
Copy link
Contributor Author

Passed Non-Regression STC for the bug fix:

LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 317408 W: 82438 L: 82529 D: 152441
Ptnml(0-2): 1111, 37768, 81020, 37711, 1094
https://tests.stockfishchess.org/tests/view/67003ebc86d5ee47d953bc25

@Disservin Disservin added the to be merged Will be merged shortly label Oct 12, 2024
@Disservin Disservin closed this in 6592b13 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functional-change 🚀 gainer Gains elo to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants