Remove unused return type from propagate() #4708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstembera
force-pushed
the
propagateReturn
branch
from
ed76935
to
281980d
Compare
Make two AffineTransform and AffineTransformSparseInput static methods constexpr. No functional change bench: 1601764
mstembera
force-pushed
the
propagateReturn
branch
from
281980d
to
aac9ef4
Compare
|
Looks good to me. Any speed measurement for the impact of the constexpr? |
|
|
|
Thanks. There should be no speed difference because the static get_index methods only get called at startup to load the weights. I mostly made them constexpr just because they can be and for consistency with the other static get_hash_value() method right above. |
|
merged via cb22520, thanks! |
Joachim26
pushed a commit
to Joachim26/StockfishNPS
that referenced
this pull request
Aug 15, 2023
Also make two get_weight_index() static methods constexpr, for consistency with the other static get_hash_value() method right above. Tested for speed by user Torom (thanks). closes official-stockfish#4708 No functional change
Joachim26
pushed a commit
to Joachim26/StockfishNPS
that referenced
this pull request
Oct 17, 2023
Also make two get_weight_index() static methods constexpr, for consistency with the other static get_hash_value() method right above. Tested for speed by user Torom (thanks). closes official-stockfish#4708 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused return type from propagate()
Make two AffineTransform and AffineTransformSparseInput static methods constexpr
No functional change
bench: 1601764