Simplify qSearch initial ttEntry saving. #4706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peregrineshahin
force-pushed
the
simpleSave2
branch
from
2596f7f
to
3f9d2f7
Compare
peregrineshahin
force-pushed
the
simpleSave2
branch
2 times, most recently
from
93613f2
to
cb46403
Compare
The Best Value is the Static Evaluation of the position if we don't have this position in the transposition table before the moves loop and the static evaluation is guaranteed to be inside the table-base range, no need for adjusting the score for table-base ranges when saving that entry. Passed STC: https://tests.stockfishchess.org/tests/view/64bccf96dc56e1650abb34ed LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 98688 W: 25319 L: 25169 D: 48200 Ptnml(0-2): 300, 11073, 26480, 11159, 332 No functional change
peregrineshahin
force-pushed
the
simpleSave2
branch
from
cb46403
to
592d39c
Compare
|
TBH I don't like this PR anymore, Maybe keeping it consistent with other calls is the way to go instead of writing such a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Best Value is the Static Evaluation of the position if we don't have this position in the transposition table before the moves loop and the static evaluation is guaranteed to be inside the table-base range, no need for adjusting the score for table-base ranges when saving that entry.
Passed STC:
https://tests.stockfishchess.org/tests/view/64bccf96dc56e1650abb34ed
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 98688 W: 25319 L: 25169 D: 48200
Ptnml(0-2): 300, 11073, 26480, 11159, 332
No functional change