Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify qSearch initial ttEntry saving. #4706

Closed

Conversation

peregrineshahin
Copy link
Contributor

@peregrineshahin peregrineshahin commented Jul 23, 2023

The Best Value is the Static Evaluation of the position if we don't have this position in the transposition table before the moves loop and the static evaluation is guaranteed to be inside the table-base range, no need for adjusting the score for table-base ranges when saving that entry.

Passed STC:
https://tests.stockfishchess.org/tests/view/64bccf96dc56e1650abb34ed
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 98688 W: 25319 L: 25169 D: 48200
Ptnml(0-2): 300, 11073, 26480, 11159, 332

No functional change

The Best Value is the Static Evaluation of the position if we don't have this position in the transposition table before the moves loop and the static evaluation is guaranteed to be inside the table-base range, no need for adjusting the score for table-base ranges when saving that entry.

Passed STC:
https://tests.stockfishchess.org/tests/view/64bccf96dc56e1650abb34ed
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 98688 W: 25319 L: 25169 D: 48200
Ptnml(0-2): 300, 11073, 26480, 11159, 332

No functional change
@peregrineshahin
Copy link
Contributor Author

TBH I don't like this PR anymore, Maybe keeping it consistent with other calls is the way to go instead of writing such a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants