Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dishwasher attributes #31

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Conversation

ofalvai
Copy link
Owner

@ofalvai ofalvai commented Oct 23, 2021

Resolves #28

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #31 (67a8ed4) into main (e799fc6) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   88.82%   89.52%   +0.69%     
==========================================
  Files           6        6              
  Lines         555      563       +8     
==========================================
+ Hits          493      504      +11     
+ Misses         62       59       -3     
Impacted Files Coverage Δ
custom_components/candy/client/model.py 82.65% <100.00%> (+2.18%) ⬆️
custom_components/candy/sensor.py 98.85% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e799fc6...67a8ed4. Read the comment docs.

@github-actions
Copy link

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ manifest.json file exist
✅ All required keys are present in manifest.json
✅ hacs.json has the 'name' key set
✅ The repository has a description
✅ candy is added to https://github.com/home-assistant/brands NICE!
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Saturday)
✅ README.md exists
✅ Requirements validation
✅ Python wheels
✅ HACS load check

@ofalvai ofalvai merged commit 715cc38 into main Oct 23, 2021
@ofalvai ofalvai deleted the dishwasher-extra-attributes branch October 23, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please add support for additional parameters for dishwasher
1 participant