Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, refactor client tests #138

Merged
merged 5 commits into from
Jun 26, 2022
Merged

Update dependencies, refactor client tests #138

merged 5 commits into from
Jun 26, 2022

Conversation

ofalvai
Copy link
Owner

@ofalvai ofalvai commented Jun 26, 2022

An update to pytest-homeassistant-custom-component introduced pytest-socket, failing all tests that try to use a socket. This conflicts with the tests in test_client.py because the aresponses library uses real connections for mocking.

And hence the rewrite.

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #138 (73d66c7) into main (e12c893) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files           7        7           
  Lines         597      597           
=======================================
  Hits          585      585           
  Misses         12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e12c893...73d66c7. Read the comment docs.

@ofalvai ofalvai merged commit 7bd117f into main Jun 26, 2022
@ofalvai ofalvai deleted the update-deps branch June 26, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant