Conversation
- Use latest toolchain (autotools) and update files - Update rpm spec w/ latest version and get rid of *la exclude - Get rid of distutils from Python and use setuptools
* configure: Replace use of AC_EGREP_CPP Use AC_COMPILE_IFELSE instead to compute platform support for arp ioctls AC_EGREP_CPP does not work as used with upcoming autoconf 2.72 Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Oliver Falk <oliver@linux-kernel.at>
Nothing actually uses this define, other `HAVE_*` defines are equally unused in C code.
tun(4) needs `<sys/types.h>` just like bpf(4) does. This builds `src/tun-bsd.c` instead of `src/tun-none.c` on OpenBSD.
`struct rt_msghdr` is a structure, so it has no symbol. Look for a member like autoconf's script and include required headers as per https://man.openbsd.org/route.4 to correctly detect this feature on OpenBSD. Not sure how this could've worked on Linux. #81
https://man.openbsd.org/sysctl.2 needs extra headers, like the others.
`HAVE_NET_IF_ARP_H` is entirely unused and might as well be removed, but fix it first while sweeping through BSD configure/compile errors. `src/arp-ioctl.h` includes this header, but it is (no longer) used on BSDs.
https://man.openbsd.org/pf.4 ought to be used on OpenBSD, this makes it build `src/fw-pf.c` instead of `src/fw-none.c`.
The official net/libdnet port has been carrying this patch since 2012[0], when the ioctl interface was reworked. Current 1.16.4 fails to compile without it. Guard our local patch under `__OpenBSD__` just to be sure. FreeBSD for example uses its own libdnet fork[1] which still seems to be fine without this patch[2]. 0: openbsd/ports@c4b4fc9 1: https://cgit.freebsd.org/ports/commit/net/libdnet/Makefile?id=b7f05445c00f2625aa19b4154ebcbce5ed2daa52 2: https://github.com/5u623l20/libdnet/blob/2d51667e6ea3a26be84a2027a238bfced1364e5d/src/intf.c
OpenBSD: Drop SIOCSIFNETMASK before SIOCSIFADDR
CMake: BSD: More feature detection fixes
CMake install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.