Merged
Conversation
here too the fields are incorrectly sized, you can understand even by the htons function in the icmp_pack_hdr_mask macro.
Owner
|
Likewise to #101 - I think it's uint32 because of ICMPv6, but maybe I'm missing something. |
Owner
Yes, likewise, 16bit are enough. |
Author
|
In ICMPv6 there is no query mask. And in icmp4 its id and seq fields are 16 bits. In RFC 590 it is not written directly, but by the ASCII art of the header, you can see that the size of these fields is 16 bits. To prove it I can attach screenshots from wireshark, where you can see that this message has everything as I say, https://i.imgur.com/NVYUKJi.png |
ofalk
added a commit
that referenced
this pull request
Jul 13, 2025
* Encoding fixes * CI Config (a few iterations) w/ Ubuntu and Windows target * Typo fixes * Fixes in icmp.h (#100 #101) - wrong size of fields for icmp4 timestamp message / 16bits are enough for Id/Seq. * Fix payload size of Netlink message (#99) - The `len` parameter of `NLMSG_LENGTH` was size of Netlink header instead of RtNetlink header. * python/dnet.pyx: fix incompatible-function-pointer-types for modern compiler (#104) * Cythonize with latest Cython (3.1) * Fix #109 PF_PACKET support detection to failure * tree-wide: regenerate autotools files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here too the fields are incorrectly sized, you can understand even by the htons function in the icmp_pack_hdr_mask macro.