Change thermistors from top-level to Motor #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thermistor apply_config now called in Motor::apply_config() Thermistor errors rolled into motor errors odrivetool and GUI updated to handle change Removed CurrentLimiter,Thermistor arrays abstraction
samuelsadok
reviewed
Oct 19, 2020
Updated API Migration Notes Changed Axis error that is thrown for over temp from ERROR_OVER_TEMP to ERROR_MOTOR_FAILED Moved setting of thermistor_.motor_ = this from motor apply_config() to motor constructor Moved motor_thermistor apply_config call from Motor to config_apply_all() in main.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #505. In addition, motor thermistors have been broken on devel for some time; this PR fixes that.
Changes:
fet_thermistorandmotor_thermistorare now members of theMotorclassmotor_thermistorrequires some initialization -apply_config()method added for this purposeThermistor errors rolled into motor errors
odrivetool and GUI updated to handle change
Removed CurrentLimiter, Thermistor arrays abstraction.
motor_thermistorandfet_thermistorget_current_limit()anddo_checks()methods are called explicitly.